Benjamin Otte [Wed, 19 Feb 2020 03:44:41 +0000 (04:44 +0100)]
gtk: Bubble drag events like motion events
Emit crossing events - with a new GTK_CROSSING_DROP type - like we do
for motion events. There is no more special casing for them.
Note that the gesture has not been updated yet, so some obscure behavior
may occur.
Benjamin Otte [Wed, 19 Feb 2020 03:43:03 +0000 (04:43 +0100)]
events: Use GdkDrop as event sequence
This allows treating drop events like touch events, which GTK groups by
event sequence.
It's a bit ugly that we just case the GdkDrop pointer, but event
sequences are only meant to be unique pointer ids, so it's fine.
Benjamin Otte [Sat, 22 Feb 2020 04:46:58 +0000 (05:46 +0100)]
widget: Simplify adjust_allocation()
And in particular, only do it if the widget doesn't use ALIGN_FILL.
This avoids lots of measuring in the common case and speeds up
size_allocate() by about 25%.
And because size_allocate() is the bottleneck in the fishbowl, this also
gets ~25% more fishies.
Benjamin Otte [Sat, 22 Feb 2020 04:25:14 +0000 (05:25 +0100)]
widget: Pull margin computation out of adjust_allocation
It's way cheaper to just do it.
Also simplifies adjust_size_allocation a lot.
Benjamin Otte [Sat, 22 Feb 2020 04:23:41 +0000 (05:23 +0100)]
sizerequest: Stop clamping for_size to natural size
Widgets should be given the actual size they will be allocated, so they
can do something with it.
If they want to clamp themselves to their natural size, nothing's
stopping them, they know their natural size after all.
Benjamin Otte [Sat, 22 Feb 2020 01:47:41 +0000 (02:47 +0100)]
widget: Don't check for natives
It's the native's job to request a 1px x 1px size, not the job of
gtk_widget_size_allocate()
Also saves 10% of size_allocate() time because checking for an interface
is really expensive.
Benjamin Otte [Sat, 22 Feb 2020 03:49:52 +0000 (04:49 +0100)]
Ensure all natives request at least a 1px wide surface
FIXME: Is this necessary?
Could the surfaces just clamp to 1x1 themselves?
We recently declared that surfaces can decide on whatever size they want
so natives need to inspect the size they requested anyway.
Matthias Clasen [Sat, 22 Feb 2020 03:19:01 +0000 (03:19 +0000)]
Merge branch 'color-float-fix' into 'master'
color chooser: Fix fallout from floatification
See merge request GNOME/gtk!1459
Matthias Clasen [Sat, 22 Feb 2020 00:56:44 +0000 (19:56 -0500)]
color chooser: Fix fallout from floatification
We are using (dddd) variants to store colors in variants,
which is dangerous now that GdkRGBA members are just floats.
Avoid passsing the GdkRGBA members directly to any varargs
functions.
Matthias Clasen [Sat, 22 Feb 2020 00:27:59 +0000 (00:27 +0000)]
Merge branch 'wip/xdg-popup-layout-no-op' into 'master'
gdk/wayland: Avoid relayout with the same properties
See merge request GNOME/gtk!1457
Matthias Clasen [Sat, 22 Feb 2020 00:26:42 +0000 (00:26 +0000)]
Merge branch 'wip/gdkpopuplayout-section' into 'master'
docs: Add GdkPopupLayout to gdk4-sections.txt
See merge request GNOME/gtk!1458
Jonas Ådahl [Fri, 21 Feb 2020 22:24:38 +0000 (23:24 +0100)]
docs: Add GdkPopupLayout to gdk4-sections.txt
Jonas Ådahl [Fri, 21 Feb 2020 20:30:42 +0000 (21:30 +0100)]
gdk/wayland: Avoid relayout with the same properties
When a popup is already showing, and gdk_surface_present_popup() is
called, if the layout didn't change, we're not really interested in
relayouting.
In the future, we'll be able to get notified if position of the popup
would change by some environmental changes, but until then, just don't
support it.
Jonas Ådahl [Fri, 21 Feb 2020 20:28:03 +0000 (21:28 +0100)]
gdk/popup-layout: Remove leftover struct field
The layouts never "seal", as they did in an earlier revision, so remove
the seal field.
Benjamin Otte [Fri, 21 Feb 2020 20:35:47 +0000 (20:35 +0000)]
Merge branch 'wip/otte/for-master' into 'master'
surface: Don't take a display argument in gdk_surface_new_popup()
See merge request GNOME/gtk!1456
Benjamin Otte [Fri, 21 Feb 2020 20:13:09 +0000 (21:13 +0100)]
surface: Don't take a display argument in gdk_surface_new_popup()
The display can be taken from the surface, it must not be different.
Benjamin Otte [Fri, 21 Feb 2020 18:24:56 +0000 (18:24 +0000)]
Merge branch 'wip/otte/for-master' into 'master'
Wip/otte/for master
See merge request GNOME/gtk!1455
Benjamin Otte [Fri, 21 Feb 2020 17:30:13 +0000 (18:30 +0100)]
transform: Don't crash for gsk_transform_transform (id, id)
See attached tests
Benjamin Otte [Fri, 21 Feb 2020 17:25:05 +0000 (18:25 +0100)]
transform: Make sure the identity transform is equal to NULL
Benjamin Otte [Wed, 19 Feb 2020 03:41:28 +0000 (04:41 +0100)]
x11: When clearing old Drop, emit LEAVE event
This can happen when the old DND operation died (like due to a crash or
a broken XWayland compositor.
Benjamin Otte [Wed, 19 Feb 2020 02:37:23 +0000 (03:37 +0100)]
gdk: Make DRAG_ENTER event take x/y coordinates
Make it mirror the behavior of ENTER/LEAVE events.
Benjamin Otte [Wed, 19 Feb 2020 23:02:19 +0000 (00:02 +0100)]
transform: Add optimization for common case
Transforming identity by an other transform does not mean we need to
painstakingly apply the individual steps of other to construct a new
transform, it means we can just return other.
Or in math terms:
I * B = B
so just return B.
Piotr Drąg [Fri, 21 Feb 2020 17:11:15 +0000 (18:11 +0100)]
Update POTFILES.in
Matthias Clasen [Fri, 21 Feb 2020 12:26:19 +0000 (07:26 -0500)]
profiling: Avoid one extra printf
We already format the message, no need to use
printf again to combine that with the kind string.
Matthias Clasen [Fri, 21 Feb 2020 12:23:40 +0000 (07:23 -0500)]
profiling: Avoid criticals
With events no longer GObjects, the type class is
longer around for peeking.
Matthias Clasen [Fri, 21 Feb 2020 06:18:25 +0000 (06:18 +0000)]
Merge branch 'readonly-events-1' into 'master'
Redo events
See merge request GNOME/gtk!1443
Matthias Clasen [Fri, 21 Feb 2020 02:29:00 +0000 (21:29 -0500)]
docs: Remove some no-longer existing api
Matthias Clasen [Fri, 21 Feb 2020 02:28:05 +0000 (21:28 -0500)]
Stop exporting gtk_get_event_widget
This is non-essential convenience API, and we
don't really expose events to applications anymore.
Matthias Clasen [Fri, 21 Feb 2020 02:27:26 +0000 (21:27 -0500)]
gtk-demo: Stop using gtk_get_event_widget
This is convenience api that will be going away.
Matthias Clasen [Fri, 21 Feb 2020 02:22:16 +0000 (21:22 -0500)]
gdk: Drop event structs from the headers
All events are GdkEvents now.
Matthias Clasen [Fri, 21 Feb 2020 02:21:45 +0000 (21:21 -0500)]
gtk: Stop using GtkEventButton
Same as the previous commit. All events are
just GdkEvents now.
Matthias Clasen [Fri, 21 Feb 2020 02:21:08 +0000 (21:21 -0500)]
gtk: Stop using GdkEventKey
We should just use GdkEvent, instead of taking
a GdkEventKey, and then cast it everywhere.
Matthias Clasen [Fri, 21 Feb 2020 02:20:05 +0000 (21:20 -0500)]
a11y: drop unused code
We are no longer using key snoopers.
Matthias Clasen [Fri, 21 Feb 2020 04:20:58 +0000 (23:20 -0500)]
motion controller: Match focus event propagation
Make the crossing event generation for pointer events
match what we do for focus now.
Matthias Clasen [Thu, 20 Feb 2020 22:22:03 +0000 (17:22 -0500)]
Keep more event controller api private
We don't want to expose the GtkCrossingData struct, and manually
feeding events to event controllers is not something we want to
encourage, going forward.
Matthias Clasen [Thu, 20 Feb 2020 22:13:21 +0000 (17:13 -0500)]
Stop exporting check_event_sanity
Matthias Clasen [Thu, 20 Feb 2020 12:30:15 +0000 (07:30 -0500)]
Bring back im context focus-in/out
The key controller still needs to track focus,
in order to emit these signals when required.
Matthias Clasen [Thu, 20 Feb 2020 03:04:28 +0000 (22:04 -0500)]
Go back to ::enter/::leave for pointer changes
These signals are behaving a little differently from
what ::focus-in/::focus-out used to do.
Matthias Clasen [Thu, 20 Feb 2020 01:51:03 +0000 (20:51 -0500)]
Split off GtkEventControllerFocus
Split the focus tracking into a separate
GtkEventControllerFocus, and change the API one more time.
We are back to having ::focus-in and ::focus-out signals.
Update all users.
Matthias Clasen [Wed, 19 Feb 2020 04:30:16 +0000 (23:30 -0500)]
wip: Add more information to crossing events
Add fields for direct descendents to GtkCrossingData,
and populate them when emitting focus change events.
Also add accessors for these fields to GtkEventControllerKey,
and verify that they are set properly in the focus test.
Not done yet: Do the same for pointer crossing events.
Matthias Clasen [Tue, 18 Feb 2020 05:38:55 +0000 (00:38 -0500)]
win32: Remove some leftover event struct access
And leftover old event api calls.
Matthias Clasen [Tue, 18 Feb 2020 05:40:48 +0000 (00:40 -0500)]
wayland: Fix a release build warning
Matthias Clasen [Tue, 18 Feb 2020 05:12:59 +0000 (00:12 -0500)]
Update the focus test
This needs an update to handle the new focus-change signal.
Matthias Clasen [Tue, 18 Feb 2020 04:45:06 +0000 (23:45 -0500)]
Update event docs section
Matthias Clasen [Tue, 18 Feb 2020 04:44:35 +0000 (23:44 -0500)]
Clean up GdkEventType docs
Matthias Clasen [Tue, 18 Feb 2020 04:08:44 +0000 (23:08 -0500)]
Some event struct packing improvements
Rearrange a few things, and move some booleans
into the Any struct, by using a bitfield there.
Some more cleanup could be done - the flags field
with its PENDING and FLUSHED members appears
entirely unused. Nobody is setting those flags.
Matthias Clasen [Tue, 18 Feb 2020 03:20:01 +0000 (22:20 -0500)]
Streamline event structs
Use proper types (GdkModifierType, double), and drop
some unused fields (send_event, display).
Matthias Clasen [Tue, 18 Feb 2020 04:20:05 +0000 (23:20 -0500)]
x11: Remove some leftover event struct access
Matthias Clasen [Tue, 18 Feb 2020 03:18:56 +0000 (22:18 -0500)]
x11: Stop using the send_event event field
The only use of this field is printing it out in a
debug message. We are going to drop it.
Matthias Clasen [Mon, 17 Feb 2020 14:17:42 +0000 (09:17 -0500)]
Always deliver focus events to toplevels
Its was GTK expects. This change gets rid of the "Ignoring an
unexpected focus event from GDK on a non-toplevel surface."
warning.
Matthias Clasen [Mon, 17 Feb 2020 12:40:31 +0000 (07:40 -0500)]
Drop gtk_widget_event from API
We don't want events to be injected randomly from
the outside. Plus, there's no way to create such
events from the outside now.
Matthias Clasen [Tue, 18 Feb 2020 03:11:56 +0000 (22:11 -0500)]
events: reorganize getters
Restructure the getters for event fields to
be more targeted at particular event types.
Update all callers, and replace all direct
event struct access with getters.
As a side-effect, this drops some unused getters.
Matthias Clasen [Tue, 18 Feb 2020 03:11:03 +0000 (22:11 -0500)]
Drop gdk_set/get_show_events
We don't need a separate api to turn on debugging
for events.
Matthias Clasen [Sun, 16 Feb 2020 16:09:02 +0000 (11:09 -0500)]
Strip const from GdkEvent
Events are refcounted structs, and we generally don't
pass these as const.
Matthias Clasen [Sun, 16 Feb 2020 07:53:44 +0000 (02:53 -0500)]
events: Drop all setters
GdkEvent is now truly readonly.
Matthias Clasen [Sun, 16 Feb 2020 07:50:34 +0000 (02:50 -0500)]
events: Drop target and related target
GTK no longer uses this, so we can drop it.
Matthias Clasen [Sun, 16 Feb 2020 07:50:09 +0000 (02:50 -0500)]
main: Stop calling gdk_event_set_target
GTK is no longer relying on this.
Matthias Clasen [Sun, 16 Feb 2020 07:47:39 +0000 (02:47 -0500)]
Stop using gdk_event_get_target
We can now get the target widget from the gesture
that we are using to find the event in the first
place.
Matthias Clasen [Sun, 16 Feb 2020 07:46:40 +0000 (02:46 -0500)]
gesture: Keep the target widget for events
We already store the events; keep the target widget
in addition. This is a step towards getting rid of
gdk_event_get_target.
Matthias Clasen [Sun, 16 Feb 2020 07:46:05 +0000 (02:46 -0500)]
eventcontroller: Make the target widget available
Make it possible for event controllers to obtain
the target widget during handle_event.
Matthias Clasen [Sun, 16 Feb 2020 07:20:34 +0000 (02:20 -0500)]
Explicitly pass the target to handle_event
Pass the event propagation target explicitly down to
the event controllers. This is a step towards getting
rid of gdk_event_set_target.
Matthias Clasen [Sun, 16 Feb 2020 06:50:39 +0000 (01:50 -0500)]
Stop looking at the related target for filtering
We are now sending crossing events (which are the only ones
where a related target makes sense) via handle_crossing.
Matthias Clasen [Sun, 16 Feb 2020 06:48:50 +0000 (01:48 -0500)]
Reinstate filtering for crossing events
The event propagation limit should apply to crossing events
as well.
Matthias Clasen [Sun, 16 Feb 2020 01:47:23 +0000 (20:47 -0500)]
Make crossing events handled the same way
Matthias Clasen [Thu, 13 Feb 2020 01:26:29 +0000 (20:26 -0500)]
New focus change handling
Instead of relying on gdk's antiquated crossing events,
create a new GtkCrossingData struct that contains the
actual widgets, and a new event controller vfunc that
expects this struct. This also saves us from making sense
of X's crossing modes and details, and makes for a
generally simpler api.
The ::focus-in and ::focus-out signals of GtkEventControllerKey
have been replaced by a single ::focus-change signal that
takes GtkCrossingData as an argument. All callers have
been updated.
Matthias Clasen [Sun, 16 Feb 2020 04:33:17 +0000 (23:33 -0500)]
wip: scrolledwindow stop using targets
Matthias Clasen [Sun, 16 Feb 2020 02:04:58 +0000 (21:04 -0500)]
main: Drop gtk_get_event_target
This is no longer used.
Matthias Clasen [Tue, 18 Feb 2020 02:21:05 +0000 (21:21 -0500)]
tooltip: stop using gtk_get_event_target
Matthias Clasen [Sun, 16 Feb 2020 02:04:08 +0000 (21:04 -0500)]
Stop using gtk_get_event_target
This is just a thin wrapper around gdk_event_get_target,
so use that directly.
Matthias Clasen [Thu, 13 Feb 2020 05:08:49 +0000 (00:08 -0500)]
Pass translated coordinates outside the event
We want to make events readonly, so stop translating
their coordinates and instead pass the translated
coordinates separately, when propagating events.
Matthias Clasen [Sun, 16 Feb 2020 05:39:11 +0000 (00:39 -0500)]
Drop GDK_NOTHING
Events of type GDK_NOTHING are good for nothing.
Matthias Clasen [Sat, 15 Feb 2020 20:40:03 +0000 (15:40 -0500)]
Make GdkEvent a boxed type
Matthias Clasen [Sat, 15 Feb 2020 20:07:24 +0000 (15:07 -0500)]
Stop using g_object_ref/unref on events
Use gdk_event_ref/unref instead of g_object_ref/unref.
Events will stop being object soon.
Matthias Clasen [Sat, 15 Feb 2020 19:22:33 +0000 (14:22 -0500)]
Drop gdk_event_new and gdk_event_copy
These functions are no longer used outside of gdkevents.c.
Matthias Clasen [Sat, 15 Feb 2020 19:19:50 +0000 (14:19 -0500)]
display: Stop using gdk_event_copy
Events are effectively readonly in GDK now, so we can just
take a reference, no need for a copy.
Matthias Clasen [Sat, 15 Feb 2020 18:23:55 +0000 (13:23 -0500)]
win32: Use event constructors
Matthias Clasen [Tue, 18 Feb 2020 05:19:26 +0000 (00:19 -0500)]
x11: Pass the right surface to the dnd filter
Matthias Clasen [Sat, 15 Feb 2020 15:45:28 +0000 (10:45 -0500)]
x11: Remove an unnecessary check
We are not creating GDK_NOTHING events anymore. Yay
Matthias Clasen [Sat, 15 Feb 2020 17:09:31 +0000 (12:09 -0500)]
x11: change event translator interface
Make the event translator return a new event, instead of
filling in a half-constructed one.
Update the two implementation in GdkX11Display and
GdkDeviceManagerXI2.
Matthias Clasen [Sat, 15 Feb 2020 15:43:29 +0000 (10:43 -0500)]
x11: Change the wm protocols filter api
Instead of passing a half-constructed event and expect
it to be filled in, pass the surface as in argument, and
add an out argument for a newly constructed GdkEvent.
Matthias Clasen [Sat, 15 Feb 2020 15:34:28 +0000 (10:34 -0500)]
x11: Don't pass a GdkEvent to shape cache filters
The filter functions never look at that event, and
we want to get out of the business of passing half-
constructed events around.
Matthias Clasen [Sat, 15 Feb 2020 15:30:55 +0000 (10:30 -0500)]
x11: Don't pass a GdkEvent to xsettings filters
The filter functions never look at that event, and
we want to get out of the business of passing half-
constructed events around.
Matthias Clasen [Sat, 15 Feb 2020 16:19:59 +0000 (11:19 -0500)]
events: Drop GDK_DESTROY
No backend is emitting GDK_DESTROY events anymore, so no
need to carry this around.
Matthias Clasen [Sat, 15 Feb 2020 16:11:13 +0000 (11:11 -0500)]
gtk: Stop handling GDK_DESTROY differently from GDK_DELETE
We don't have child windows anymore, so there is no difference.
Matthias Clasen [Sat, 15 Feb 2020 16:12:22 +0000 (11:12 -0500)]
x11: Don't generate GDK_DESTROY events
GTK does not differentiate between GDK_DESTROY and GDK_DELETE
anyway.
Matthias Clasen [Sat, 15 Feb 2020 14:33:53 +0000 (09:33 -0500)]
x11: use event constructors
This is not quite complete and only handles the
simple cases.
Matthias Clasen [Sat, 15 Feb 2020 00:07:09 +0000 (19:07 -0500)]
broadway: Use event constructors
Convert all of Broadways event handling to use the new
constructors.
Matthias Clasen [Sat, 15 Feb 2020 15:12:41 +0000 (10:12 -0500)]
wip: Use event constructors in the testsuite
This doesn't work because the constructors aren't exported,
so remove the gestures text temporarily, until we figure
out how to deal with it.
Matthias Clasen [Sat, 15 Feb 2020 19:07:09 +0000 (14:07 -0500)]
textview: Stop using gdk_event_copy
Matthias Clasen [Sat, 15 Feb 2020 19:06:43 +0000 (14:06 -0500)]
main: Use constructors instead of gdk_event_copy + rewriting
Matthias Clasen [Sat, 15 Feb 2020 14:55:58 +0000 (09:55 -0500)]
imcontextsimple: Use event constructors
Matthias Clasen [Sat, 15 Feb 2020 00:29:12 +0000 (19:29 -0500)]
widget: Port emulation code to constructors
Use the new event constructors when generating events
for emulating presses.
Matthias Clasen [Sat, 15 Feb 2020 15:13:19 +0000 (10:13 -0500)]
window: Use event constructors
Matthias Clasen [Sat, 15 Feb 2020 20:30:40 +0000 (15:30 -0500)]
main: Use event constructors
At the same time, stop setting child_surface in
crossing events. Nothing in GTK looks at it.
Matthias Clasen [Sat, 15 Feb 2020 18:19:48 +0000 (13:19 -0500)]
gdk: Use constructor for grab broken
Matthias Clasen [Sat, 15 Feb 2020 14:36:19 +0000 (09:36 -0500)]
gdk: Use event constructors for dnd
Matthias Clasen [Fri, 14 Feb 2020 23:23:45 +0000 (18:23 -0500)]
events: Drop x_root/y_root
We are not using these fields anymore.
Matthias Clasen [Fri, 14 Feb 2020 23:19:13 +0000 (18:19 -0500)]
broadway: Stop setting x_root/y_root in events
These fields are not used in GTK anymore, and are
going away soon.
Matthias Clasen [Fri, 14 Feb 2020 23:18:10 +0000 (18:18 -0500)]
x11: Stop setting x_root/y_root in events
These fields are not used by GTK anymore and
will be going away soon.
Matthias Clasen [Fri, 14 Feb 2020 23:17:13 +0000 (18:17 -0500)]
x11: Stop relying on root coordinates in events
The X11 dnd code was still using x_root/y_root in
GdkEventMotion in a couple of places. Stop doing so,
these field are going away soon.